Enhance Snowpark Session Handling with Optional Injection #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the ChatSnowflakeCortex class to accept an existing Snowpark session object as an optional parameter. If provided, the session is validated for correctness and activity. If no session is given, a new session is created using environment variables. This enhancement improves flexibility in session management.
…ocumentation Removed the internal session creation tracking and streamlined the validation process for external Snowpark sessions. Updated the documentation to clarify the usage of environment variables and constructor parameters for session management, enhancing overall clarity and usability.
|
Looks like it needs to be run through linting |
|
Okay, I'll give that a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the flexibility of the Snowpark session configuration by allowing an optional session object to be injected. If a session is provided, it will be used directly instead of initializing a new one from environment variables. This change simplifies testing and integration scenarios where session reuse is preferred. Additionally, the environment validation logic has been updated to skip checks when a session is already supplied.
Fixes #150