fix(genai): Support Langchain ProviderStrategy for Gemini models#1466
Open
Juan Felipe Arias (juanfe88) wants to merge 4 commits intolangchain-ai:mainfrom
Open
fix(genai): Support Langchain ProviderStrategy for Gemini models#1466Juan Felipe Arias (juanfe88) wants to merge 4 commits intolangchain-ai:mainfrom
Juan Felipe Arias (juanfe88) wants to merge 4 commits intolangchain-ai:mainfrom
Conversation
…tting response_format kwargs and add related examples and tests.
Juan Felipe Arias (juanfe88)
changed the title
Juan Felipe Arias (juanfe88)
changed the title
Author
|
Hello Mason Daugherty (@mdrxy), Hope you're doing well. I have noticed you are one of the active maintainers of the repo. Can I get this PR reviewed please ? 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added handling for the bind arguments passed by Langchain's implementation of provider strategy aka native structured output
Relevant issues
Fixes #1384
Type
🐛 Bug Fix
Changes(optional)
Testing(optional)
Note(optional)
Currently the fix is only applied for the ChatGoogleGenerativeAI class as it is the current one, but it could be expanded to ChatVertexAI one if necessary