-
Notifications
You must be signed in to change notification settings - Fork 18
feat: introducing watsonx sql database wrapper and toolkit #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
if not isinstance(content, str) or length <= 0: | ||
return content | ||
|
||
if len(content) <= length: | ||
return content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be combined into 1 if statement using the second or
unless you want to split it for some reason like clarity?
@@ -13,7 +13,11 @@ license = "MIT" | |||
[tool.poetry.dependencies] | |||
python = ">=3.10,<3.14" | |||
langchain-core = "^0.3.39" | |||
ibm-watsonx-ai = "^1.3.28" | |||
ibm-watsonx-ai = "^1.3.32" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it be updated to 1.3.34 or it is not necessary?
The goal of this PR is to add
WatsonxSQLDatabase
andWatsonxSQLDatabaseToolkit
to langchain_ibm.Example