Prototype with new class AutoEmbeddingVectorStore and test_autoembedd…#204
Draft
Casey Clements (caseyclements) wants to merge 3 commits intolangchain-ai:mainfrom
Draft
Prototype with new class AutoEmbeddingVectorStore and test_autoembedd…#204Casey Clements (caseyclements) wants to merge 3 commits intolangchain-ai:mainfrom
Casey Clements (caseyclements) wants to merge 3 commits intolangchain-ai:mainfrom
Conversation
| def from_texts( | ||
| cls, | ||
| texts: List[str], | ||
| embedding: Embeddings = VoyageAIEmbeddings(model="voyage-3-large"), |
Collaborator
There was a problem hiding this comment.
This is not needed since the search index is handling this
Collaborator
Author
There was a problem hiding this comment.
This is a red herring. I added from_texts as it is abstractmethod. I wasn't using it for the test. embedding is a required argument to the base VectorStore's constructors.
…and standrd test suite passes. Added #TODO to fold AutoEmbeddingVectorStore into core one.
Collaborator
Author
|
Jib (@Jibola) I am going to close this unless you can think of a reason to keep it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a draft PR, for testing and discussion.