INTPYTHON-377 langgraph-checkpoint-mongodb #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseyclements
changed the title
…langchain-ai/langgraph
vbarda
reviewed
Nov 21, 2024
Contributor
vbarda
left a comment
vbarda
left a comment
There was a problem hiding this comment.
Looks good to me! for final version we'd need to remove the pregel test files. will let you know once standard test lib is ready :)
libs/langgraph-checkpoint-mongodb/langgraph/checkpoint/mongodb/aio.py
Outdated
Show resolved
Hide resolved
Contributor
Discussed offline -- we can merge as is and rip those tests out as soon as standard tests lib is published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2nd package in this repo:
langgraph-checkpoint-mongodbImplements two new graph checkpointers for MongoDB. One synchronous and one asynchronous.
This closely follows the other implementations in checkpoint, checkpoint-postgres, checkpoint-sqlite but with NoSQL idioms.
This is work that was originally in a pull-request directly to langgraph (#2089)
In the review of #2089, we were told that there were additional tests that truly verified the checkpointers, this file for sync and this file for async. This PR will be marled draft until these are all green.