Skip to content

community[minor]: 06 - Refactoring PDFPlumber #29709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 40 commits into from
Closed

community[minor]: 06 - Refactoring PDFPlumber #29709

wants to merge 40 commits into from

Conversation

@pprados
Copy link
Contributor

@pprados pprados commented Feb 10, 2025 •
edited
Loading

Modify PDFPlumber to:

  • separate into loader/parser components
  • identify tables in PDFs
  • process images in PDFs like other parsers
  • support multi-threading

@vercel
Copy link

vercel bot commented Feb 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2025 9:26am

@pprados pprados mentioned this pull request Feb 10, 2025
Closed
2 tasks
@pprados pprados force-pushed the pprados/06-pdfplumber branch from d812a18 to d3c94a3 Compare February 10, 2025 09:46
@pprados pprados force-pushed the pprados/06-pdfplumber branch from d3c94a3 to d90dde5 Compare February 10, 2025 10:09
@pprados pprados marked this pull request as ready for review February 10, 2025 10:20
@pprados
Copy link
Contributor Author

pprados commented Feb 10, 2025

@eyurtsev the next.
I use a special approach to handle capitalized properties. I hope this works for you.
If not, we can “double” the keys to maintain compatibility.

@pprados pprados force-pushed the pprados/06-pdfplumber branch from d90dde5 to 535e222 Compare February 10, 2025 10:33
@pprados
Copy link
Contributor Author

pprados commented Feb 12, 2025

@eyurtsev ping

eyurtsev
eyurtsev approved these changes Feb 16, 2025
View reviewed changes
@dosubot dosubot bot added the lgtm label Feb 16, 2025
This was referenced Mar 24, 2025
Closed
Merged
@pprados
Copy link
Contributor Author

pprados commented Mar 26, 2025

@eyurtsev
To fix the Issue 30454 can you merge this PR?

Note: Current implemention of PDFPlumber has several limitations:

  • It does not provide a parser
  • Uses load()`` instead of lazy_load()`
  • Does not handle tables
  • Does not support image conversions.

@pprados
Merge remote-tracking branch 'upstream/master' into pprados/06-pdfplu…
2ec0aa3 
…mber

# Conflicts:
#	docs/docs/integrations/document_loaders/pdfplumber.ipynb
#	docs/docs/integrations/document_loaders/pypdfium2.ipynb
#	docs/docs/integrations/document_loaders/pypdfloader.ipynb
@pprados pprados marked this pull request as draft April 3, 2025 16:24
@pprados pprados force-pushed the pprados/06-pdfplumber branch from 3a932f8 to 028069c Compare April 15, 2025 09:59
@pprados pprados marked this pull request as ready for review April 15, 2025 11:03
@pprados pprados mentioned this pull request Apr 15, 2025
Open
pprados added 2 commits April 29, 2025 11:03
@pprados
Merge remote-tracking branch 'upstream/master' into pprados/06-pdfplu…
dbb69b6 
…mber

# Conflicts:
#	libs/community/langchain_community/document_loaders/parsers/pdf.py
#	libs/community/langchain_community/document_loaders/pdf.py
@pprados
Remove type: ignore
f9420e9
@pprados
Copy link
Contributor Author

pprados commented Apr 29, 2025

@ccurme or @baskaryan, can you review this PR?

ccurme
ccurme reviewed Apr 29, 2025
View reviewed changes
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing as langchain-community has been moved to a standalone repo: https://github.com/langchain-ai/langchain-community

@ccurme ccurme closed this Apr 29, 2025
@github-project-automation github-project-automation bot moved this from In review to Closed in PR Reviews Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eyurtsev eyurtsev eyurtsev approved these changes

@ccurme ccurme ccurme left review comments

@baskaryan baskaryan Awaiting requested review from baskaryan

Assignees

@eyurtsev eyurtsev

Labels

None yet

Projects

No open projects
PR Reviews
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pprados @eyurtsev @ccurme