Skip to content

Conversation

@cbornet
Copy link
Collaborator

@cbornet cbornet commented Oct 28, 2025

As per its doc BaseTool args_schema can be a Pydantic v1 model.
This PR fixes TypeBaseModel so it includes pydantic.v1.BaseModel.
This detected a few places in the code where a v1 args_schema results in an exception:

  • runnable.get_input_schema(config).model_fields --> get_fields(runnable.get_input_schema(config))
  • runnable.get_input_schema(config).model_json() --> runnable.get_input_jsonschema(config)

@cbornet cbornet requested a review from eyurtsev as a code owner October 28, 2025 12:46
@github-actions github-actions bot added fix core Related to the package `langchain-core` and removed fix labels Oct 28, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 28, 2025

CodSpeed Performance Report

Merging #33698 will not alter performance

Comparing cbornet:pydantic-v1-runnable (28754b8) with master (62769a0)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched
⏩ 21 skipped1

Footnotes

  1. 21 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions github-actions bot added fix and removed fix labels Oct 28, 2025
@cbornet cbornet force-pushed the pydantic-v1-runnable branch from 59b686e to b9fcc04 Compare October 28, 2025 13:01
@github-actions github-actions bot added the langchain Related to the package `langchain` label Oct 28, 2025
@cbornet cbornet force-pushed the pydantic-v1-runnable branch from b9fcc04 to 28754b8 Compare October 28, 2025 13:07
@github-actions github-actions bot added fix and removed fix labels Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Related to the package `langchain-core` fix langchain Related to the package `langchain`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant