Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ def wrap_model_call(
# Try fallback models
for fallback_model in self.models:
request.model = fallback_model
request.model_settings = {}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you do this using override? request = request.override(model=fallback_model)

try:
return handler(request)
except Exception as e: # noqa: BLE001
Expand Down Expand Up @@ -128,6 +129,7 @@ async def awrap_model_call(
# Try fallback models
for fallback_model in self.models:
request.model = fallback_model
request.model_settings = {}
try:
return await handler(request)
except Exception as e: # noqa: BLE001
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -213,3 +213,59 @@ async def mock_handler(req: ModelRequest) -> ModelResponse:

with pytest.raises(ValueError, match="Model failed"):
await middleware.awrap_model_call(request, mock_handler)


def test_model_settings_cleared_on_fallback() -> None:
"""Test that model_settings are cleared when falling back to another model."""

class FailingPrimaryModel(GenericFakeChatModel):
def _generate(self, messages, **kwargs):
raise ValueError("Primary model failed")

primary_model = FailingPrimaryModel(messages=iter([]))
fallback_model = GenericFakeChatModel(messages=iter([AIMessage(content="fallback")]))

middleware = ModelFallbackMiddleware(fallback_model)
request = _make_request()
request.model = primary_model
request.model_settings = {"cache_control": {"type": "ephemeral", "ttl": "5m"}}

def mock_handler(req: ModelRequest) -> ModelResponse:
# Verify model_settings are empty for fallback model
if req.model is fallback_model:
assert req.model_settings == {}
result = req.model.invoke([])
return ModelResponse(result=[result])

response = middleware.wrap_model_call(request, mock_handler)

assert isinstance(response, ModelResponse)
assert request.model_settings == {}


async def test_model_settings_cleared_on_fallback_async() -> None:
"""Test async version - model_settings are cleared when falling back."""

class AsyncFailingPrimaryModel(GenericFakeChatModel):
async def _agenerate(self, messages, **kwargs):
raise ValueError("Primary model failed")

primary_model = AsyncFailingPrimaryModel(messages=iter([]))
fallback_model = GenericFakeChatModel(messages=iter([AIMessage(content="fallback")]))

middleware = ModelFallbackMiddleware(fallback_model)
request = _make_request()
request.model = primary_model
request.model_settings = {"cache_control": {"type": "ephemeral", "ttl": "5m"}}

async def mock_handler(req: ModelRequest) -> ModelResponse:
# Verify model_settings are empty for fallback model
if req.model is fallback_model:
assert req.model_settings == {}
result = await req.model.ainvoke([])
return ModelResponse(result=[result])

response = await middleware.awrap_model_call(request, mock_handler)

assert isinstance(response, ModelResponse)
assert request.model_settings == {}