fix(openai): make GPT-5 temperature validation case-insensitive #34012
+35
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where GPT-5 temperature validation was case-sensitive, causing issues when users
specified Azure deployment names or model names in uppercase (e.g.,
"GPT-5-2025-01-01","GPT-5-NANO"). The validation now correctly handles model names regardless of case.Changes made:
validate_temperature()method inBaseChatOpenAIto perform case-insensitivemodel name comparisons
_get_encoding_model()method to use case-insensitive checks for tiktoken encoderselection
combinations
Issue: Fixes #34003
Dependencies: None
Test Coverage:
test_gpt_5_temperature_case_insensitivecovers uppercase, lowercase, andmixed-case model names
preserved)
make lint,make format)