Skip to content

Conversation

@ccurme
Copy link
Collaborator

@ccurme ccurme commented Nov 19, 2025

No description provided.

@ccurme ccurme requested review from eyurtsev and mdrxy November 19, 2025 15:35
@github-actions github-actions bot added feature documentation Improvements or additions to documentation integration Related to a provider partner package integration core Related to the package `langchain-core` dependencies Pull requests that update a dependency file model-profiles anthropic and removed feature labels Nov 19, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 19, 2025

CodSpeed Performance Report

Merging #34024 will degrade performances by 23.77%

Comparing cc/model_profiles_distributed (4fd9c77) with master (525d5c0)1

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

❌ 2 regressions
✅ 26 untouched
⏩ 6 skipped2

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
WallTime test_async_callbacks_in_sync 18.4 ms 24.2 ms -23.77%
WallTime test_import_time[HumanMessage] 236.9 ms 263.6 ms -10.11%

Footnotes

  1. No successful run was found on master (ee3373a) during the generation of this report, so 525d5c0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Comment on lines 1623 to 1629
@model_validator(mode="after")
def _set_model_profile(self) -> Self:
"""Set model profile if not overridden."""
if not self.profile:
self.profile = MODEL_PROFILES.get(self.model)

return self
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a field validator I think?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it needs to be a model validator because it relies on another field self.model for the lookup.

@github-actions github-actions bot added langchain Related to the package `langchain` openai labels Nov 20, 2025
@ccurme ccurme changed the title feat(model-profiles): (RFC / draft) distribute data across packages feat(model-profiles): distribute data across packages Nov 20, 2025
@ccurme ccurme marked this pull request as ready for review November 20, 2025 18:57
@github-actions github-actions bot added feature and removed documentation Improvements or additions to documentation labels Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

anthropic core Related to the package `langchain-core` deepseek dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation feature fireworks groq huggingface integration Related to a provider partner package integration langchain Related to the package `langchain` mistralai model-profiles openai perplexity xai

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants