feat(model-profiles): distribute data across packages #34024
Conversation
github-actions
bot
added
feature
documentation
CodSpeed Performance ReportMerging #34024 will degrade performances by 23.77%Comparing
|
| Mode | Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|---|
| ❌ | WallTime | test_async_callbacks_in_sync |
18.4 ms | 24.2 ms | -23.77% |
| ❌ | WallTime | test_import_time[HumanMessage] |
236.9 ms | 263.6 ms | -10.11% |
Footnotes
-
No successful run was found on
master(ee3373a) during the generation of this report, so 525d5c0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩ -
6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
| @model_validator(mode="after") | ||
| def _set_model_profile(self) -> Self: | ||
| """Set model profile if not overridden.""" | ||
| if not self.profile: | ||
| self.profile = MODEL_PROFILES.get(self.model) | ||
|
|
||
| return self |
There was a problem hiding this comment.
this should be a field validator I think?
There was a problem hiding this comment.
I think it needs to be a model validator because it relies on another field self.model for the lookup.
ccurme
changed the title
github-actions
bot
added
feature
and removed
documentation
github-actions
bot
added
documentation
No description provided.