fix(core): lazy loading transformers, numpy, simsimd#35466
Open
Won-Kyu Park (wkpark) wants to merge 2 commits intolangchain-ai:masterfrom
Open
fix(core): lazy loading transformers, numpy, simsimd#35466Won-Kyu Park (wkpark) wants to merge 2 commits intolangchain-ai:masterfrom
Won-Kyu Park (wkpark) wants to merge 2 commits intolangchain-ai:masterfrom
Conversation
Merging this PR will improve performance by 20.01%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | test_import_time[InMemoryVectorStore] |
651 ms | 542.5 ms | +20.01% |
Comparing wkpark:lazy_load_numpy_transformers (b5f28ac) with master (e939c96)
Footnotes
-
23 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
88e4983 to
a0b778f
Compare
fix transformer lint
fix numpy lint
a0b778f to
b5f28ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(core): lazy loading transformers, numpy, simsimd
Summary
Optimized the initial import speed of langchain_core by converting top-level imports of transformers, numpy, and simsimd into lazy, local imports.
Details
Confirmed with python -X importtime that these dependencies are no longer loaded on initial import, and verified functionality through make format/lint and est.
Disclaimer
I used the Gemini CLI to help with the specific implementation details and to ensure compliance with linting and type checking and drafting this PR description.
before
without transformers / torch env.
with transformers / torch installed env.
after