fix(docs): update an outdated middleware example#10146
Merged
Christian Bromann (christian-bromann) merged 3 commits intolangchain-ai:mainfrom Feb 24, 2026
Merged
fix(docs): update an outdated middleware example#10146Christian Bromann (christian-bromann) merged 3 commits intolangchain-ai:mainfrom
Christian Bromann (christian-bromann) merged 3 commits intolangchain-ai:mainfrom
Conversation
🦋 Changeset detectedLatest commit: a2e58c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Copilot started reviewing on behalf of
Dmytro Tiapukhin (eddienubes)
February 24, 2026 20:29
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the middleware JSDoc example to reflect the current middleware hook signature where controls is no longer injected into hooks.
Changes:
- Updates
beforeModelexample signature to remove thecontrolsparameter. - Replaces
controls.terminate(...)with throwing an error in the example.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Christian Bromann (christian-bromann)
approved these changes
Feb 24, 2026
Member
Christian Bromann (christian-bromann)
left a comment
There was a problem hiding this comment.
Great catch 👌
67cc069
into
langchain-ai:main
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Middleware hooks don't have
controlsparameter injected into them anymore.My LLM accidentally pointed out that I should be using
controls.terminateto terminate the agent loop referring to this line. However, it's not actual anymore according to the types.