fix(@langchain/google) Fixes for ID in Vertex function calls#10292
Merged
Hunter Lovell (hntrl) merged 4 commits intolangchain-ai:mainfrom Mar 17, 2026
Merged
fix(@langchain/google) Fixes for ID in Vertex function calls#10292Hunter Lovell (hntrl) merged 4 commits intolangchain-ai:mainfrom
Hunter Lovell (hntrl) merged 4 commits intolangchain-ai:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 6407c8f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Allen Firstenberg (afirstenberg)
changed the title
Hunter Lovell (hntrl)
approved these changes
Mar 10, 2026
| toolCalls.push({ | ||
| type: "tool_call", | ||
| id: functionCallPart.functionCall.id ?? uuidv4().replace(/-/g, ""), | ||
| id: functionCallPart.functionCall.id ?? `lc-tool-call-${uuidv4().replace(/-/g, "")}`, |
There was a problem hiding this comment.
and i'm guessing that second condition will only ever be met by vertex?
Contributor
Author
There was a problem hiding this comment.
The second condition should only be met if it uses a generated ID. But it is aimed at when it happens on Vertex, yes.
Hunter Lovell (hntrl)
force-pushed
the
vertex-function-id
branch
from
ccfbf32 to
7da8095
Compare
…ing sent back to Gemini, which is not expecting them. Test for same.
Hunter Lovell (hntrl)
force-pushed
the
vertex-function-id
branch
from
7da8095 to
b4e5285
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vertex does not accept IDs for function responses, considering it an invalid field. LangChain requires an ID to match responses to requests, so a previous fix added a synthetic ID for this purpose.
Changed this synthetic ID to match a known pattern so it could be removed when sending the results back to Gemini.
Added tests.
Integration tests pass with the following exception:
Fixes #10266