fix(google): lazy-load jose in CJS auth helpers#10407
Merged
Hunter Lovell (hntrl) merged 3 commits intolangchain-ai:mainfrom Mar 17, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: ad6cafd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
LGTM |
Contributor
|
great work fahe1em1 ! |
Hunter Lovell (hntrl)
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
joseinside the GCP auth helpers so the CJS bundle no longer eagerlyrequire()an ESM-only dependency@langchain/google/nodejoseuntil a signing helper is actually usedFixes #10403.
Why this is safe
This only changes when
joseis loaded. The affected helpers were already async, so switching them to fetchjoselazily preserves behavior while avoiding theERR_REQUIRE_ESMcrash in CommonJS runtimes.Validation
pnpm --filter @langchain/google test -- src/utils/tests/gcp-auth.test.tspnpm --filter @langchain/google buildpnpm --filter @langchain/google lint