fix(google): avoid double-counting cached tokens in input_token_details.text#10440
Open
guoyangzhen (guoyangzhen) wants to merge 1 commit intolangchain-ai:mainfrom
Open
Conversation
…ls.text Gemini's promptTokensDetails[TEXT] includes cached tokens, but LangSmith calculates cost as (text * regular_price) + (cache_read * discounted_price). This caused cached tokens to be billed twice. Subtract cache_read from text modality count to avoid overlap. Fixes langchain-ai#10339
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using
@langchain/googlewith Gemini models that support implicit caching,input_token_details.textincludes all text tokens (including cached ones), whileinput_token_details.cache_readalso counts the cached tokens. This causes LangSmith to double-count cached tokens when calculating costs.LangSmith calculates cost as:
Since
textincludes cached tokens, those tokens are charged at both the regular rate and the discounted cache rate.Root Cause
In
convertGeminiGenerateContentResponseToUsageMetadata, Gemini'spromptTokensDetails[TEXT]modality count equals the total text tokens (including cached). The code sets bothtextandcache_readwithout adjusting for the overlap.Fix
Subtract
cache_readfromtextmodality count so the values don't overlap, matching how cost is calculated in LangSmith.Fixes #10339