Skip to content

Conversation

durran
Copy link
Contributor

@durran durran commented Jul 30, 2025

This PR updates the MongoDB integration vector store tests to be able to use Azure OpenID, with a fallback to OpenID if the necessary environment variables are not there. This is due to us switching in our own integration test suite. (https://github.com/mongodb-labs/ai-ml-pipeline-testing)

The sister pull request to this is mongodb-labs/ai-ml-pipeline-testing#89 in our other repo.

Copy link

vercel bot commented Jul 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jul 31, 2025 10:51am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Jul 31, 2025 10:51am

@@ -39,6 +39,7 @@
},
"devDependencies": {
"@jest/globals": "^29.5.0",
"@langchain/azure-openai": "workspace:*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've actually inlined our azure implementation to @langchain/openai and we largely don't update that package anymore (we need to do a formal deprecation of it!). Since you're already importing embeddings from @langchain/openai, could you remove this dep?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency removed now.

@hntrl
Copy link
Contributor

hntrl commented Jul 31, 2025

Also if you could run yarn lint && yarn format from the root to unstick CI that would be much appreciated!

@durran
Copy link
Contributor Author

durran commented Jul 31, 2025

Also if you could run yarn lint && yarn format from the root to unstick CI that would be much appreciated!

Done.

@durran durran requested a review from hntrl July 31, 2025 10:55
@hntrl hntrl merged commit f3a9881 into langchain-ai:main Jul 31, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants