-
Notifications
You must be signed in to change notification settings - Fork 2.9k
chore(*): build system improvements #9288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: e748cf0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2261d31 to
c2f1122
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we are revisiting this: the idea of defining entry points via src property in exports of package.json I think made sense when we defined all build configs within @langchain/build. Now that we go back to workspace config files we could also define entry points there, e.g. as getBuildConfig parameter?
I don't see anything wrong with the current approach, except it is not standard conferment and vitest gets confused by this. What are your thoughts here?
Could you elaborate more on this? Do you mean we should be changing how the entry config option is populated? I saw that tsdown has an |
|
Currently package entries are defines within "./callbacks/base": {
"input": "./src/callbacks/base.ts",
"require": {
"types": "./dist/callbacks/base.d.cts",
"default": "./dist/callbacks/base.cjs"
},
"import": {
"types": "./dist/callbacks/base.d.ts",
"default": "./dist/callbacks/base.js"
}
},This is not standard conferment and other tools may get thrown off by this. Using this exports function would be great, can we give this a shot? |
Fixes #9252
Fixes #9268