fix(aws): add lc_aliases for model_id/region_name in ChatBedrockConverse #9322
+43
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing lc_aliases mapping to correctly handle deserialization of model configuration from LangSmith Hub prompts. LangSmith Hub stores prompts with Python naming (model_id, region_name), but the JS SDK expects JavaScript property names (model, region). Without these aliases, pulling prompts with includeModel: true would fail to load the model configuration, causing fallback to defaults. - Add model -> model_id and region -> region_name aliases - Add test to verify deserialization works correctly
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ChatBedrockConversewas missinglc_aliasesto map Python naming conventions (model_id,region_name) from LangSmith Hub to JavaScript property names (model,region). This caused model configuration to not load correctly when pulling prompts withincludeModel: true.Solution
Added
lc_aliasesmapping formodel→model_idandregion→region_name, matching the pattern used inBedrockChat.Changes
modelandregionaliases toChatBedrockConverse.lc_aliases()