fix: clean shared messages state in case of history rewrite#93
Open
Aleksandr Vishniakov (asvishnyakov) wants to merge 2 commits intolangchain-ai:mainfrom
Open
fix: clean shared messages state in case of history rewrite#93Aleksandr Vishniakov (asvishnyakov) wants to merge 2 commits intolangchain-ai:mainfrom
Aleksandr Vishniakov (asvishnyakov) wants to merge 2 commits intolangchain-ai:mainfrom
Conversation
Author
|
Faris Mohammed (@farisnanosoft) Sydney Runkle (@sydney-runkle) Eugene Yurtsev (@eyurtsev) I’d appreciate any feedback if you think this isn’t the right fix for the issue, as I’m currently experiencing it in my project. |
Aleksandr Vishniakov (asvishnyakov)
changed the title
Author
|
Sydney Runkle (@sydney-runkle) May you look into this please? |
Author
|
Sydney Runkle (@sydney-runkle) Eugene Yurtsev (@eyurtsev) May someone take a look on this, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the
messagesfield is cumulative, overwriting history in any of the swarm agents causes the history update (such as a message summary) to be appended to the end. For example:Agent 1:
Agent 2:
Then Agent 2 overwrites the history:
And when handing off back to Agent 1, this happens:
This not only disrupts the flow of the conversation but also causes issues if the summary is a system message (such as in
langmem'sSummarizationNode).On the other hand, if history is not overwritten, everything continues to work correctly after changes made in this PR, since the "removed" messages will simply be replaced by themselves.
Fixes #84.