fix(cli): secure ZIP extraction against Path Traversal (Zip Slip)#6750
Open
RinZ27 wants to merge 1 commit intolangchain-ai:mainfrom
Open
fix(cli): secure ZIP extraction against Path Traversal (Zip Slip)#6750RinZ27 wants to merge 1 commit intolangchain-ai:mainfrom
RinZ27 wants to merge 1 commit intolangchain-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of
_download_repo_with_requestsuseszip_file.extractall(path), which is vulnerable to Path Traversal (Zip Slip) attacks. If a malicious template or a compromised repository is used, an attacker could potentially overwrite arbitrary files outside the target directory.I've replaced the unsafe extraction with a secure loop that validates each member's path using
os.path.commonpath(via prefix checking) to ensure all extracted files remain within the intended destination.Dependencies
None.
Twitter handle
@RinZ27 (if applicable)