feat(cli): use dynamic validation for Node.js version instead of hardcoded values#1889
Draft
christian-bromann wants to merge 2 commits intomainfrom
Draft
feat(cli): use dynamic validation for Node.js version instead of hardcoded values#1889christian-bromann wants to merge 2 commits intomainfrom
christian-bromann wants to merge 2 commits intomainfrom
Conversation
…coded values
Replace hardcoded Node.js version literals ("20", "22", "24") with a flexible
validation schema that accepts any version string with major version >= 20.
This allows future Node.js versions to work automatically without code changes.
- Add MIN_NODE_VERSION constant (20) for validation
- Update default Node version to 24
- Add comprehensive unit tests for version validation
🦋 Changeset detectedLatest commit: f6abdac The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"20","22","24") inNodeVersionSchemawith a dynamic validation that accepts any version string where the major version is >= 20"20"to"24"Motivation
Previously, adding support for new Node.js versions required updating the hardcoded list in
NodeVersionSchema. This change makes the validation future-proof by validating that the major version is at least 20 (the minimum supported version), allowing any current or future Node.js version to work automatically.The schema now:
"20","22","24","26", etc."20.10.0","22.1.5", etc."18","19.9.0", etc."invalid","abc.def.ghi", etc.