feat(store): enhance PostgresStore to support shared pg.Pool instances#1966
Open
jadengis wants to merge 1 commit intolangchain-ai:mainfrom
Open
feat(store): enhance PostgresStore to support shared pg.Pool instances#1966jadengis wants to merge 1 commit intolangchain-ai:mainfrom
jadengis wants to merge 1 commit intolangchain-ai:mainfrom
Conversation
🦋 Changeset detectedLatest commit: d104269 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- Updated PostgresStoreConfig to accept a preconfigured pg.Pool. - Added fromPool static method for creating PostgresStore instances from an existing pool. - Modified connection handling to allow sharing a pool between PostgresStore and PostgresSaver. - Updated stop method to conditionally close the pool based on ownership. - Added integration tests for pool sharing functionality.
jadengis
force-pushed
the
store-pool-share
branch
from
87ae46c to
d104269
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PostgresSaver supports passing in a preconfigured pool instance. PostgresStore should support this as well, otherwise you will need to have two Pools running per server in order to use these features in tandem. This puts a lot of connection pressure on the database.
Changes