Fix search query generation when model generates thinking tags#88
Open
William John Shipman (williamjshipman) wants to merge 2 commits intolangchain-ai:mainfrom
Open
Fix search query generation when model generates thinking tags#88William John Shipman (williamjshipman) wants to merge 2 commits intolangchain-ai:mainfrom
William John Shipman (williamjshipman) wants to merge 2 commits intolangchain-ai:mainfrom
Conversation
|
Came across: https://ollama.com/MFDoom/deepseek-r1-tool-calling:32b I wonder if this would also solve the structured output expectations(?) |
Author
|
I gave this model a quick test, although just the 1.5b parameter version. Still fails to generate JSON. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into an issue using LMStudio with the qwq-32b, deepseek-r1-distill-qwen-7b and deepseek-r1-llama-8b models. In the generate_query and reflect_on_summary steps, the models return text with thinking tags before the actual JSON. With the DeepSeek models, I also saw that DeepSeek recommended using to enclose an example of the desired output. This pull request updates the reflect_on_summary prompt with example tags and moves the stripping of think tags to earlier both reflect_on_summary and generate_query so the JSON part of the response can be parsed.