Skip to content

Conversation

@Anchaliya75
Copy link

@Anchaliya75 Anchaliya75 commented Apr 13, 2025

Make Worker Liveness Probe Path Configurable

Description

This PR makes the liveness probe path configurable for the Langfuse worker deployment while maintaining "/api/health" as the default path.

Changes

  • Added support for configurable liveness probe path through .Values.langfuse.worker.livenessProbe.path
  • Set default value to "/api/health" if no custom path is specified
  • Maintains backward compatibility with existing deployments

Testing

  • Tested with default configuration
  • Tested with custom probe path
  • Verified backward compatibility

Important

Makes liveness probe path configurable in deployment.yaml, defaulting to "/api/health" for backward compatibility.

  • Behavior:
    • Makes liveness probe path configurable in deployment.yaml via .Values.langfuse.worker.livenessProbe.path.
    • Default path remains "/api/health" if not specified.
    • Ensures backward compatibility with existing deployments.
  • Testing:
    • Verified with default and custom liveness probe paths.
    • Confirmed backward compatibility.

This description was created by Ellipsis for dc1ce94. It will automatically update as commits are pushed.

@Anchaliya75 Anchaliya75 requested a review from Steffen911 as a code owner April 13, 2025 07:45
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 13, 2025
@CLAassistant
Copy link

CLAassistant commented Apr 13, 2025

CLA assistant check
All committers have signed the CLA.

@Steffen911
Copy link
Member

@Anchaliya75 Could you share why this configurability is desirable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants