Skip to content

Update openai.py to handle where OpenAI Agents SDK sends an Omit type #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update openai.py to handle where OpenAI Agents SDK sends an Omit type #1426

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cc621e
Update openai.py
druce Nov 3, 2025
d3264bf
Merge branch 'main' into patch-1
druce Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion langfuse/openai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
from inspect import isclass
from typing import Any, Optional, cast

from openai._types import NotGiven
from openai._types import NotGiven, Omit
from packaging.version import Version
from pydantic import BaseModel
from wrapt import wrap_function_wrapper
Expand Down Expand Up @@ -398,6 +398,7 @@ def _get_langfuse_data_from_kwargs(resource: OpenAiDefinition, kwargs: Any) -> A
if (
metadata is not None
and not isinstance(metadata, NotGiven)
and not isinstance(metadata, Omit)
and not isinstance(metadata, dict)
):
raise TypeError("metadata must be a dictionary")
Expand Down