Skip to content

fix: add option to force keep_trace_attributes in langfuse #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: add option to force keep_trace_attributes in langfuse #1434

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d36dfc
option to force keep_trace_attributes in langfuse
philipshurpik Nov 11, 2025
a0f22d5
Update langfuse/langchain/CallbackHandler.py
philipshurpik Nov 11, 2025
d65cedc
Merge branch 'main' into fix/option-to-force-keep-trace-attributes
philipshurpik Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions langfuse/langchain/CallbackHandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,16 +792,15 @@ def __on_llm_action(
if registered_prompt:
self._deregister_langfuse_prompt(parent_run_id)

# keep trace attributes if llm is run isolated and outside chain or forced in metadata
keep_trace_attributes = bool((metadata or {}).get('keep_trace_attributes') or parent_run_id is None)
content = {
"name": self.get_langchain_run_name(serialized, **kwargs),
"input": prompts,
"metadata": self.__join_tags_and_metadata(
tags,
metadata,
# If llm is run isolated and outside chain, keep trace attributes
keep_langfuse_trace_attributes=True
if parent_run_id is None
else False,
keep_langfuse_trace_attributes=keep_trace_attributes,
),
"model": model_name,
"model_parameters": self._parse_model_parameters(kwargs),
Expand Down