Feature Architecture & CI Improvements #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a feature registry and auto-discovery system under modules/features/ to manage version-specific configuration logic. Adds base classes and decorators for feature registration, semantic version comparison, and applies features in global, infrastructure, plugins, and services modules. Implements features for trigger worker, plugin metrics, and external Prometheus (3.7.0+). Updates i18n translations and documentation to reflect the new architecture and configuration options. Includes tests for feature registration, version parsing, and applicability.
Added generate-image-repo-secret.sh for interactively creating Kubernetes imagePullSecret for private Docker registries. Updated .gitignore to better exclude sensitive files. Added utils/secrets.py for secret key generation. Updated README files with instructions for using the new secret generator script.
- Add test job to validate all Python module imports - Add feature tests, services tests, and S3 config tests - Add shell script validation with shellcheck - Update actions to v4/v5 versions - Add CI integration test plan documentation
test_services.py and test_s3_config.py require interactive input, skip them until --ci mode is implemented
Collaborator
Author
|
@sorphwer Please review and let me know if you’d like any changes—happy to iterate. |
- Add set_ci_mode() and is_ci_mode() to config.py - Add --ci flag to generate-values-prd.py - Update utils/prompts.py to return defaults in CI mode - Update i18n/language.py to use English in CI mode - Update utils/downloader.py to use latest version in CI mode - Update version_manager.py to avoid variable shadowing - Enable CI mode in test files for non-interactive testing
Collaborator
Author
|
the feature test function has been added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Description
This PR introduces a feature-based architecture for version-specific configurations and improves CI testing capabilities.
✨ Changes
1. Feature-Based Architecture (
modules/features/)2. Docker Registry Secret Generator
generate-image-repo-secret.shfor creating Kubernetes imagePullSecrets.gitignorewith more precise sensitive file patternsutils/secrets.pyfor secret key generation3. CI Improvements
test_features.py)4. Documentation
docs/CI-INTEGRATION-PLAN.mdfor future integration test roadmap🔧 Type of Change
✅ Checklist
🧪 Testing
📝 Notes
test_services.pyandtest_s3_config.pyare skipped in CI (require interactive input)--cimode (tracked indocs/CI-INTEGRATION-PLAN.md)