Skip to content

Comments

fix: fix cot_output parser#2430

Open
fatelei wants to merge 1 commit intolanggenius:mainfrom
fatelei:issue-31034
Open

fix: fix cot_output parser#2430
fatelei wants to merge 1 commit intolanggenius:mainfrom
fatelei:issue-31034

Conversation

@fatelei
Copy link
Contributor

@fatelei fatelei commented Jan 15, 2026

fix issue langgenius/dify#31034

after

Screen.Recording.2026-01-23.at.21.13.49.mov

This PR contains Changes to Non-Plugin

  • Documentation
  • Other

This PR contains Changes to Non-LLM Models Plugin

  • I have Run Comprehensive Tests Relevant to My Changes

This PR contains Changes to LLM Models Plugin

  • My Changes Affect Message Flow Handling (System Messages and User→Assistant Turn-Taking)
  • My Changes Affect Tool Interaction Flow (Multi-Round Usage and Output Handling, for both Agent App and Agent Node)
  • My Changes Affect Multimodal Input Handling (Images, PDFs, Audio, Video, etc.)
  • My Changes Affect Multimodal Output Generation (Images, Audio, Video, etc.)
  • My Changes Affect Structured Output Format (JSON, XML, etc.)
  • My Changes Affect Token Consumption Metrics
  • My Changes Affect Other LLM Functionalities (Reasoning Process, Grounding, Prompt Caching, etc.)
  • Other Changes (Add New Models, Fix Model Parameters etc.)

Version Control (Any Changes to the Plugin Will Require Bumping the Version)

  • I have Bumped Up the Version in Manifest.yaml (Top-Level Version Field, Not in Meta Section)

Dify Plugin SDK Version

  • I have Ensured dify_plugin>=0.3.0,<0.6.0 is in requirements.txt (SDK docs)

Environment Verification (If Any Code Changes)

Local Deployment Environment

  • Dify Version is: , I have Tested My Changes on Local Deployment Dify with a Clean Environment That Matches the Production Configuration.

SaaS Environment

  • I have Tested My Changes on cloud.dify.ai with a Clean Environment That Matches the Production Configuration

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 15, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical parsing error within the cot_output component of the cot_agent plugin, which was causing functionality issues in the previous version. The changes primarily focus on refining the PrefixMatcher class's step method by eliminating redundant state tracking and simplifying character processing. This ensures more robust and accurate interpretation of agent outputs, thereby stabilizing the plugin's core functionality.

Highlights

  • Bug Fix: Addresses a reported issue where the cot_output parser was broken in version 0.0.30 of the plugin.
  • Version Update: The cot_agent plugin version has been incremented from 0.0.30 to 0.0.31 in manifest.yaml.
  • Code Refactoring: Simplified the parsing logic in cot_output_parser.py by removing the last_character variable and associated state management, which streamlines how character deltas are processed.
  • Internal Variable Renaming: Renamed internal variables within the PrefixMatcher.step method (e.g., yield_raw_delta to yield_raw_delta_inner) to improve clarity and avoid potential naming conflicts.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@fatelei fatelei temporarily deployed to agent-strategies/cot_agent January 15, 2026 13:22 — with GitHub Actions Inactive
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix an issue with the cot_output parser by removing the logic associated with last_character. While the intent to remove this variable is clear from most of the changes, a critical issue remains in PrefixMatcher.step where last_character is still referenced after its declaration was removed. This will cause a SyntaxError and prevent the code from running. I've provided a specific comment with a code suggestion to resolve this issue.

@dosubot dosubot bot added the bug Something isn't working label Jan 15, 2026
@fatelei fatelei temporarily deployed to agent-strategies/cot_agent January 15, 2026 13:28 — with GitHub Actions Inactive
@Kevin9703
Copy link

I tried it, but it still doesn't seem to work
image

@fatelei
Copy link
Contributor Author

fatelei commented Jan 23, 2026

I tried it, but it still doesn't seem to work image

use this patch ? code has not merge, plugin has not been updated

@Kevin9703
Copy link

Kevin9703 commented Jan 23, 2026

I tried it, but it still doesn't seem to work image

use this patch ? code has not merge, plugin has not been updated

Yes, I am using this code

@fatelei
Copy link
Contributor Author

fatelei commented Jan 23, 2026

I tried it, but it still doesn't seem to work image

use this patch ? code has not merge, plugin has not been updated

Yes, I am using this code

ok, i will dig it

@fatelei
Copy link
Contributor Author

fatelei commented Jan 23, 2026

I tried it, but it still doesn't seem to work image

use this patch ? code has not merge, plugin has not been updated

image

is this expect ?

@Kevin9703
Copy link

I tried it, but it still doesn't seem to work image

use this patch ? code has not merge, plugin has not been updated

image is this expect ?

Yes, expect to call the tool normally

@fatelei
Copy link
Contributor Author

fatelei commented Jan 23, 2026

I tried it, but it still doesn't seem to work image

use this patch ? code has not merge, plugin has not been updated

image is this expect ?

Yes, expect to call the tool normally

i submit the code later

@fatelei fatelei had a problem deploying to agent-strategies/cot_agent January 23, 2026 13:13 — with GitHub Actions Failure
@fatelei fatelei had a problem deploying to agent-strategies/cot_agent January 23, 2026 13:13 — with GitHub Actions Failure
@fatelei fatelei had a problem deploying to agent-strategies/cot_agent January 23, 2026 13:14 — with GitHub Actions Failure
@fatelei
Copy link
Contributor Author

fatelei commented Jan 23, 2026

I tried it, but it still doesn't seem to work image

use this patch ? code has not merge, plugin has not been updated

image is this expect ?

Yes, expect to call the tool normally

code has been updated

This reverts commit df03592.
@amine-y
Copy link

amine-y commented Jan 30, 2026

Hello @fatelei , thank you for fixing this do you know when this will get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants