Fix: Add temperature param for azure openai gpt-5.1 and gpt-5.2 if reasoning_effort is 'None'#2476
Conversation
Summary of ChangesHello @henry-fung, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue where the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly adds the temperature parameter to the gpt-5.1 and gpt-5.2 models and introduces logic to handle its mutual exclusivity with reasoning_effort. The changes in models/azure_openai/models/constants.py are appropriate. However, I've found a bug in the conditional logic in models/azure_openai/models/llm/llm.py. The current implementation incorrectly removes the temperature parameter when reasoning_effort is not specified for certain models. I've included a suggested fix to address this issue.
|
Please sync the main branch and try it again, bump the version in the manifest as well. |
…ng_effort is set to none
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
a88e424 to
36098ed
Compare
Fix: Add temperature param for azure openai gpt-5.1 and gpt-5.2 if reasoning_effort is 'None'
Related Issues or Context
temperatureparameter is correctly passed to Azure OpenAI GPT-5.1 and GPT-5.2 models whenreasoning_effortis set to 'None', fixing unexpected behavior where temperature was ignored.This PR contains Changes to LLM Models Plugin
Version Control (Any Changes to the Plugin Will Require Bumping the Version)
VersionField, Not in Meta Section)Dify Plugin SDK Version
dify_plugin>=0.3.0,<0.6.0is in requirements.txt (SDK docs)Environment Verification (If Any Code Changes)
Local Deployment Environment