-
Notifications
You must be signed in to change notification settings - Fork 704
chore(tongyi): update tool_calls retrieval method #2522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Nov1c444, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the stability of the Tongyi model integration by resolving a Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request includes a version bump for the Tongyi plugin and a crucial fix in the llm.py file. The primary change addresses a potential KeyError by replacing getattr() with the more appropriate .get() method when retrieving tool_calls from the model's response, enhancing the robustness of the code.
| assistant_prompt_message = AssistantPromptMessage( | ||
| content=resp_content, | ||
| tool_calls=getattr(response.output.choices[0].message, "tool_calls", []), | ||
| tool_calls=response.output.choices[0].message.get("tool_calls", []), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change from getattr(response.output.choices[0].message, "tool_calls", []) to response.output.choices[0].message.get("tool_calls", []) is a good improvement. Using .get() is the idiomatic and safer way to access keys in dictionary-like objects, preventing a KeyError if the 'tool_calls' key is absent, as noted in the PR description. This enhances the code's robustness.
| tool_calls=response.output.choices[0].message.get("tool_calls", []), | |
| tool_calls=response.output.choices[0].message.get("tool_calls", []) |
Related Issues or Context
Fixes #2521
Fix KeyError: 'tool_calls' by replacing getattr() with .get() for dict-style access on the response message object.
This PR contains Changes to Non-Plugin
This PR contains Changes to Non-LLM Models Plugin
This PR contains Changes to LLM Models Plugin
Version Control (Any Changes to the Plugin Will Require Bumping the Version)
VersionField, Not in Meta Section)Dify Plugin SDK Version
dify_plugin>=0.3.0,<0.6.0is in requirements.txt (SDK docs)Environment Verification (If Any Code Changes)
Local Deployment Environment
SaaS Environment