chore(models/openrouter): sync dependencies#2562
Conversation
Summary of ChangesHello @Stream29, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on essential maintenance for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the dependencies for the OpenRouter model plugin. The main change is in requirements.txt, where the list of pinned dependencies has been drastically shortened. While the intent to sync dependencies is clear, the current implementation replaces a dependency lock file with a list of abstract dependencies. This is a critical issue that can lead to non-reproducible builds and environment-specific bugs. My review comment provides details on how to fix this by regenerating the lock file. It's crucial to use a lock file for applications and plugins to ensure stability across different environments.
| dify-plugin>=0.5.0,<0.6.0 | ||
| sniffio==1.3.1 No newline at end of file |
There was a problem hiding this comment.
This change replaces a fully pinned dependency lock file with a file containing only direct, abstract dependencies. This is a significant regression for reproducibility. A requirements.txt file for an application or plugin should be a lock file to ensure that the same versions of all dependencies (including transitive ones) are used in all environments (development, testing, production). This prevents "it works on my machine" issues and ensures stable deployments.
Please regenerate the lock file. Based on the comments in the previous version of this file and in pyproject.toml, you can do this by running the following command from the models/openrouter directory:
uv pip compile pyproject.toml -o requirements.txtThis will generate a complete, pinned list of all necessary dependencies.
Related Issues or Context
This PR contains Changes to Non-Plugin
This PR contains Changes to Non-LLM Models Plugin
This PR contains Changes to LLM Models Plugin
Version Control (Any Changes to the Plugin Will Require Bumping the Version)
VersionField, Not in Meta Section)Dify Plugin SDK Version
dify_plugin>=0.3.0,<0.6.0is in requirements.txt (SDK docs)Environment Verification (If Any Code Changes)
Local Deployment Environment
SaaS Environment