feat: add recover, make sure the process is killed

[fatelei]

Description

Please provide a brief description of the changes made in this pull request.
Please also include the issue number if this is related to an issue using the format Fixes #123 or Closes #123.

fix #30740 langgenius/dify#30740

add recover, make sure the process is killed

Type of Change

• Bug fix
• New feature
• Refactor
• Performance improvement
• Other

Essential Checklist

Testing

• I have tested the changes locally and confirmed they work as expected
• I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

• I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Please provide any additional context that would help reviewers understand the changes.

[gemini-code-assist]

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the stability of the plugin runtime by implementing a more reliable process termination strategy. It ensures that when a plugin instance shuts down, its main process and any child processes it may have spawned are properly killed and reaped, thereby preventing resource leaks and improving system hygiene. This addresses a specific bug where processes might not be killed effectively.

Highlights

• Robust Process Termination: Implemented a more robust process termination mechanism using the syscall package to ensure that all child processes spawned by a plugin are properly killed.
• Deferred Cleanup: Introduced a deferred cleanup function within StartStdout that handles process group termination (SIGKILL) and process reaping (cmd.Wait()) upon function exit, preventing zombie processes.
• Process Group Management: Configured new plugin processes (specifically Python-based ones) to run in their own process groups by setting SysProcAttr{Setpgid: true}, enabling comprehensive termination of the entire process tree.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a mechanism to reliably terminate plugin processes and their children by using process groups. The approach is sound for Unix-like systems. However, the changes introduce platform-specific code using the syscall package without the necessary build constraints, which will cause compilation to fail on non-Unix platforms like Windows. This is a critical issue that needs to be addressed. Additionally, error logging for process termination calls has been removed, which is a regression in observability and should be restored. My review includes specific comments on these points with suggestions for improvement.