refactor: unified path handle for windows and unix like system

[fatelei]

Description

fix #556

refactor: unified path handle for windows and unix like system

Type of Change

• Bug fix
• New feature
• Refactor
• Performance improvement
• Other

Essential Checklist

Testing

• I have tested the changes locally and confirmed they work as expected
• I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

• I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Please provide any additional context that would help reviewers understand the changes.

[gemini-code-assist]

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the plugin packager's path handling mechanisms to provide a unified and robust approach for interpreting file paths across different operating systems. By introducing a new path normalization utility and integrating it throughout the decoding process, the system can now consistently process plugin manifests that may use varying path separators or formats, thereby improving cross-platform compatibility and fixing a reported bug related to path resolution.

Highlights

• Unified Path Handling: Introduced a new normalizeLogicalPath utility function to standardize path strings from plugin manifests, converting them to a consistent forward-slash, relative format suitable for cross-platform use.
• Cross-Platform Compatibility: Modified FSPluginDecoder to use filepath.FromSlash when interacting with the underlying OS file system, ensuring that logical forward-slash paths from manifests are correctly translated to OS-native path separators (e.g., backslashes on Windows).
• Robust Manifest Parsing: Applied path normalization to all file paths referenced within plugin manifests (tools, endpoints, models, etc.) to ensure consistent interpretation regardless of whether paths use forward or backslashes, or contain redundant segments.
• Enhanced Testing: Added comprehensive unit tests for the new path normalization logic and extended existing decoder tests to cover scenarios involving Windows-style paths and patterns in both file system and zip-based plugin decoding.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively refactors path handling to support both Windows and Unix-like systems, which is a great improvement for cross-platform compatibility. The core logic of normalizing paths to a consistent forward-slash format is sound, and the addition of pathutil.go with its test suite is well-executed. The new tests for FSPluginDecoder and ZipPluginDecoder with various path styles are comprehensive and add a lot of confidence in the changes. My review includes a critical security note regarding a potential directory traversal vulnerability in pathutil.go. Additionally, there are several high-severity issues in pkg/plugin_packager/decoder/helper.go related to incorrect code indentation that significantly impact readability.