Skip to content

update all .first() call #25472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
asukaminato0721 wants to merge 57 commits into
base: main
Choose a base branch
from
Draft

update all .first() call #25472

asukaminato0721 wants to merge 57 commits into from
+1,323 −1,226

Conversation

@asukaminato0721
Copy link
Contributor

@asukaminato0721 asukaminato0721 commented Sep 10, 2025 •
edited
Loading

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

part of #22668.

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Copilot AI review requested due to automatic review settings September 10, 2025 06:59
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 10, 2025

This comment was marked as outdated.

Sign in to view

@dosubot dosubot bot added the 💪 enhancement New feature or request label Sep 10, 2025
gemini-code-assist[bot]

This comment was marked as outdated.

Sign in to view

gemini-code-assist[bot]

This comment was marked as outdated.

Sign in to view

@asukaminato0721 asukaminato0721 marked this pull request as draft September 10, 2025 07:18
@asukaminato0721 asukaminato0721 force-pushed the orm-query-first branch 2 times, most recently from 9bf61f3 to fcdf15c Compare September 10, 2025 08:48
@asukaminato0721 asukaminato0721 changed the title where -> filter_by for simple case use aliased for shorted name Sep 10, 2025
@asukaminato0721
ast-grep --pattern 'session.query($NAME).where($COND).first()' -r 'se…
b89b8fe 
…ssion.scalars(select($NAME).where($COND).limit(1)).first()' -l py --update-all
@asukaminato0721
ast-grep --pattern 'db.session.query($NAME).where($COND).first()' -r …
27694a6 
…'db.session.scalars(select($NAME).where($COND).limit(1)).first()' -l py --update-all
@asukaminato0721
ast-grep --pattern 'db.session.query($NAME).where($COND, $C1).first()…
ed07aff 
…' -r 'db.session.scalars(select($NAME).where($COND, $C1).limit(1)).first()' -l py
@asukaminato0721 asukaminato0721 changed the title use aliased for shorted name update all .first() call Sep 10, 2025
@asukaminato0721
more
b0734c9
@asukaminato0721
ast-grep --pattern 'db.session.query($NAME).filter_by($COND).first()'…
d722181 
… -r 'db.session.scalars(select($NAME).filter_by($COND).limit(1)).first()' -l py --update-all
@asukaminato0721
ast-grep --pattern 'db.session.query($NAME).filter_by($COND, $C1).fir…
9c27b09 
…st()' -r 'db.session.scalars(select($NAME).filter_by($COND, $C1).limit(1)).first()' -l py --update-all
@asukaminato0721
more
117b8b2
@asukaminato0721
ast-grep --pattern 'db.session.query($NAME).where($COND, $C1).first()…
7cf4eb5 
…' -r 'db.session.scalars(select($NAME).where($COND, $C1).limit(1)).first()' -l py --update-all
@asukaminato0721
more
a50070e
@asukaminato0721
Copy link
Contributor Author

asukaminato0721 commented Sep 10, 2025

need to change all mock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@laipz8200 laipz8200 Awaiting requested review from laipz8200

@hj24 hj24 Awaiting requested review from hj24 hj24 will be requested when the pull request is marked ready for review hj24 is a code owner

@zyssyz123 zyssyz123 Awaiting requested review from zyssyz123 zyssyz123 will be requested when the pull request is marked ready for review zyssyz123 is a code owner

@Mairuis Mairuis Awaiting requested review from Mairuis Mairuis will be requested when the pull request is marked ready for review Mairuis is a code owner

@Yeuoly Yeuoly Awaiting requested review from Yeuoly Yeuoly will be requested when the pull request is marked ready for review Yeuoly is a code owner

@Stream29 Stream29 Awaiting requested review from Stream29 Stream29 will be requested when the pull request is marked ready for review Stream29 is a code owner

@JohnJyong JohnJyong Awaiting requested review from JohnJyong JohnJyong will be requested when the pull request is marked ready for review JohnJyong is a code owner

@Nov1c444 Nov1c444 Awaiting requested review from Nov1c444 Nov1c444 will be requested when the pull request is marked ready for review Nov1c444 is a code owner

@QuantumGhost QuantumGhost Awaiting requested review from QuantumGhost QuantumGhost will be requested when the pull request is marked ready for review QuantumGhost is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

💪 enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@asukaminato0721