fix: base to typebase migration #26788
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced all instances of Base with TypeBase in api/models/ to leverage MappedAsDataclass for stricter type checking. This change required adding explicit type annotations to all fields in the affected models and resolving constructor argument mismatches. - Replaced Base with TypeBase in: - api/models/dataset.py - api/models/model.py - api/models/workflow.py - api/models/provider.py - api/models/oauth.py - Added Mapped type hints to all fields in the affected dataclasses. - Reordered fields in some dataclasses to satisfy dataclass constraints (fields with default values must come after fields without). - Updated constructor calls in various files to match the new dataclass `__init__` signatures. - Fixed a bug in `api/commands.py` where a `None` value could be passed to a function expecting a string.
asukaminato0721
commented
Oct 12, 2025
| created_by=account.id, | ||
| environment_variables=environment_variables, | ||
| conversation_variables=conversation_variables, | ||
| rag_pipeline_variables=rag_pipeline_variables_list, |
asukaminato0721
force-pushed
the
fix/base-to-typebase-migration
branch
2 times, most recently
from
b92d759 to
9cd31ad
Compare
asukaminato0721
force-pushed
the
fix/base-to-typebase-migration
branch
from
9cd31ad to
6fdcfd1
Compare
asukaminato0721
force-pushed
the
fix/base-to-typebase-migration
branch
from
6fdcfd1 to
f422df4
Compare
asukaminato0721
changed the title
This was referenced Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
part of #23579
Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods