Skip to content

Conversation

@asukaminato0721
Copy link
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

after merging all of #29289 part, merge this.

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Copilot AI review requested due to automatic review settings December 18, 2025 09:15
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 18, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @asukaminato0721, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the api/.ruff.toml file to integrate the flake8-tidy-imports linter, aiming to improve import consistency and code structure. It also introduces explicit guidelines to transition from flask_restx.reqparse to Pydantic for request parsing, aligning with a strategic move towards more robust data validation and serialization practices.

Highlights

  • Linter Configuration Update: The api/.ruff.toml configuration has been updated to enable the flake8-tidy-imports linter, enhancing code quality checks related to import statements.
  • Import Rule Exception: A specific rule, TID252, from flake8-tidy-imports has been added to the ignore list, which allows relative imports from parent modules within the API codebase.
  • API Usage Guidance: New banned-api rules have been introduced for flask_restx.reqparse and flask_restx.reqparse.RequestParser, providing a clear message to developers to use Pydantic for payload and query models instead.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Ruff configuration to enforce the use of Pydantic models over flask_restx.reqparse. This is a positive change that promotes modern, type-safe data validation. The changes in .ruff.toml correctly enable the flake8-tidy-imports rules and configure it to ban reqparse. I have one suggestion to make the configuration more concise by removing a redundant rule.

Comment on lines +122 to +124

[lint.flake8-tidy-imports.banned-api."flask_restx.reqparse.RequestParser"]
msg = "Use Pydantic payload/query models instead of reqparse."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Banning the flask_restx.reqparse module on line 120 is sufficient to prevent its use, including any classes or functions within it like RequestParser. According to the Ruff documentation, banning a module will flag any import from or of that module. Therefore, this second rule for flask_restx.reqparse.RequestParser is redundant and can be removed for a cleaner configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds flake8-tidy-imports linting rules to the Ruff configuration, specifically to enforce the migration from flask_restx.reqparse to Pydantic models. This is intended to be merged after PR #29289, which removes all existing reqparse usage from the codebase.

Key changes:

  • Enables the "TID" (flake8-tidy-imports) rule set in Ruff
  • Configures banned-api rules to prevent future use of flask_restx.reqparse and flask_restx.reqparse.RequestParser
  • Allows relative imports from parent modules by ignoring TID252

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant