-
Notifications
You must be signed in to change notification settings - Fork 19.9k
fix: missing content if assistant message with tool_calls #30083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @leslie2046, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug where the textual content of an assistant message would be inadvertently lost if the message also contained tool calls. The fix ensures that both the textual response and any associated tool calls are correctly preserved and represented within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a bug where the text content of an assistant's message would be lost if the message also included tool calls. The changes in fc_agent_runner.py ensure that the message content is preserved during the creation of the AssistantPromptMessage. The related fix in message_entities.py correctly updates the is_empty logic to consider messages with tool calls as non-empty. The changes are logical and well-implemented. I have added one suggestion to improve the readability of the code.
merged Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Important
Fixes #<issue number>.Summary
Fixes #30063
reasoning_contentfilled back to LLM.fix :invalid message without reasoning_content/tool_calls dify-official-plugins#2298
feat(DeepSeek): supported deepseek-reasoner multi turn thinking with tool use . dify-official-plugins#2307
Screenshots
These models with non-thinking still ok
Other thinking models still ok
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods