Skip to content

Conversation

@fatelei
Copy link
Contributor

@fatelei fatelei commented Dec 24, 2025

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #28611 #30005

allow config NEXT_PUBLIC_BATCH_CONCURRENCY

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 💪 enhancement New feature or request labels Dec 24, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new configuration option, NEXT_PUBLIC_BATCH_CONCURRENCY, allowing users to define the number of concurrent batch operations within the Dify web application. This change moves a previously hardcoded limit into a configurable environment variable, providing greater flexibility for optimizing performance and resource management, particularly for features like text generation that utilize batch processing.

Highlights

  • Configurable Batch Concurrency: Introduced a new environment variable, NEXT_PUBLIC_BATCH_CONCURRENCY, allowing users to customize the number of concurrent batch operations.
  • Dynamic Group Size: Replaced a hardcoded GROUP_SIZE value in the text generation component with the newly configurable BATCH_CONCURRENCY.
  • Frontend Integration: Integrated the BATCH_CONCURRENCY setting into the web application's global configuration and dataset attributes for dynamic access across the frontend.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new environment variable, NEXT_PUBLIC_BATCH_CONCURRENCY, to make the concurrency of batch processing configurable. The implementation correctly replaces the previously hardcoded value. My review focuses on improving the naming consistency of the new configuration key to align with existing conventions in the codebase, which will enhance readability and maintainability.

@fatelei fatelei force-pushed the issue-28611 branch 2 times, most recently from 2b65b97 to 2233ced Compare December 24, 2025 07:43
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This configuration should be added to the docker/.env.example as well.

@fatelei fatelei requested a review from laipz8200 as a code owner December 25, 2025 03:44
@fatelei
Copy link
Contributor Author

fatelei commented Dec 25, 2025

This configuration should be added to the docker/.env.example as well.

done

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 26, 2025
@crazywoola crazywoola merged commit fd64156 into langgenius:main Dec 26, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Make Batch Run App concurrency configurable (replace hardcoded GROUP_SIZE with env-based config)

2 participants