Set user to root for API and worker services

[amitshuklabag]

Fix for #29173 (comment)

[gemini-code-assist]

Summary of Changes

Hello @amitshuklabag, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a configuration change to the docker-compose.yaml file, setting the user directive to root for both the api and worker services. This modification aims to address a specific issue, likely related to permissions or execution context within the Docker containers, ensuring these critical services operate with the necessary privileges.

Highlights

• API Service Configuration: The api service in docker-compose.yaml has been updated to explicitly run as the root user.
• Worker Service Configuration: The worker service in docker-compose.yaml has been updated to explicitly run as the root user.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request sets the user for the api and worker services to root in the docker-compose.yaml file. While this might resolve an immediate permissions issue, it introduces a significant security risk by running the containers with root privileges, and it has been applied to an auto-generated file instead of its template. My review comments highlight these concerns and recommend exploring alternative solutions that adhere to the principle of least privilege and are applied to the correct source file.

[gemini-code-assist]

Running the container as the root user introduces a significant security risk by violating the principle of least privilege. It's strongly recommended to use the non-privileged dify user that is already configured in the Dockerfile. Please investigate the underlying permission issue and address it directly, for example by adjusting directory ownership.

Additionally, this change is made in the auto-generated docker-compose.yaml file. To make the change persistent, it should be applied to the api service in docker/docker-compose-template.yaml instead.

[gemini-code-assist]

As with the api service, running this container as root is a security concern. It's preferable to solve any permission errors without resorting to root privileges.

This change also needs to be made in the docker/docker-compose-template.yaml template file to ensure it persists after auto-generation.

[bowenliang123]

-1

[kurokobo]

The issue with write permissions has already been resolved in the init container. This change is unnecessary and not recommended.

[asukaminato0721]

#30109 (comment)