Skip to content

Conversation

@majiayu000
Copy link
Contributor

Summary

  • Fixed YAML anchor syntax error that caused docker compose config to fail
  • The x-shared-env anchor was defined without a value, now defined as empty map {}

Fixes #30247

Screenshots

Before After
yaml: map merge requires map or sequence of maps as the value Config generated successfully

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

The x-shared-env anchor was defined without a value, causing
docker compose config to fail with "yaml: map merge requires
map or sequence of maps as the value" error.

This fix defines the anchor as an empty map `{}` to allow proper
YAML merging in the environment sections of api and worker services.

Fixes langgenius#30247

Signed-off-by: majiayu000 <1835304752@qq.com>
@majiayu000 majiayu000 requested a review from laipz8200 as a code owner January 5, 2026 13:39
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 5, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @majiayu000, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical configuration issue within the Docker setup by fixing an improperly defined YAML anchor. The x-shared-env anchor, which was causing docker compose config to fail due to a syntax error, is now correctly initialized as an empty map. This ensures the Docker Compose configuration can be parsed and processed without errors, enhancing the stability and functionality of the deployment process.

Highlights

  • YAML Anchor Fix: Corrected a YAML anchor syntax error that previously caused the docker compose config command to fail.
  • Empty Map Definition: The x-shared-env anchor, which was previously defined without a value, is now explicitly defined as an empty map {} to resolve the syntax issue.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @majiayu000, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical syntax error in the Docker Compose configuration that prevented docker compose config from executing successfully. The fix involves explicitly defining a previously undefined YAML anchor, x-shared-env, as an empty map, thereby resolving the parsing issue and ensuring proper configuration validation.

Highlights

  • YAML Anchor Definition: The x-shared-env YAML anchor is now explicitly defined as an empty map ({}) to resolve a syntax error.
  • Docker Compose Configuration Fix: This change fixes an issue where docker compose config would fail due to an improperly defined YAML anchor, ensuring successful configuration validation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kurokobo
Copy link
Contributor

kurokobo commented Jan 5, 2026

#30247 (comment)

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a YAML syntax error in docker-compose-template.yaml by defining the x-shared-env anchor as an empty map. This makes the template file valid and parsable on its own. However, this change introduces a side effect that breaks the docker/generate_docker_compose script, which relies on a specific regex to process this template. The script will fail to remove the old anchor, resulting in a malformed docker-compose.yaml file. I've provided a specific comment on how to resolve this issue in the script.

@@ -1,4 +1,4 @@
x-shared-env: &shared-api-worker-env
x-shared-env: &shared-api-worker-env {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While this change correctly makes the YAML file valid, it inadvertently breaks the docker/generate_docker_compose script. The script's regular expression at line 63, r"^x-shared-env: &shared-api-worker-env\s*\n?", no longer matches this updated line.

This will cause the script to fail to remove this line, leading to a docker-compose.yaml with a duplicate x-shared-env key, which is invalid.

To fix this, you should update the regex in docker/generate_docker_compose to accommodate this change. Here is a suggested fix:

# In docker/generate_docker_compose at line 62
template_content = re.sub(
    r"^x-shared-env: &shared-api-worker-env.*\n?",
    "",
    template_content,
    flags=re.MULTILINE,
)

After applying this change to the script, please remember to regenerate the docker-compose.yaml file and include it in this pull request.

@majiayu000 majiayu000 closed this Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docker compose config fails with YAML anchor syntax error in docker-compose-template.yaml

2 participants