refactor: split changes for api/controllers/web/saved_message.py

[asukaminato0721]

Important

1. Make sure you have read our contribution guidelines
2. Ensure there is an associated issue and you have been assigned to it
3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

part of #29289

Screenshots

Before	After
...	...

Checklist

• This change requires a documentation update, included: Dify Document
• I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
• I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
• I've updated the documentation accordingly.
• I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

[gemini-code-assist]

Summary of Changes

Hello @asukaminato0721, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the saved_message.py controller by migrating its request argument and body parsing mechanisms from werkzeug.datastructures.RequestParser to Pydantic models. This change aims to enhance data validation, improve type safety, and increase code readability by leveraging Pydantic's declarative schema definitions for API input handling. It is part of a broader initiative to standardize how API endpoints process and validate incoming data.

Highlights

• Pydantic Migration for GET Request: The GET endpoint for saved messages now uses Pydantic's SavedMessageListQuery for validating query parameters, replacing the older reqparse.RequestParser.
• Pydantic Migration for POST Request: The POST endpoint for saving messages has been updated to use Pydantic's SavedMessageCreatePayload for validating the request body, moving away from reqparse.RequestParser.
• Schema Registration Import: An import for register_schema_models has been added, indicating a move towards a more structured approach for managing API schemas.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the request parsing in api/controllers/web/saved_message.py to use Pydantic models instead of reqparse, which is a positive change for improving validation and type safety. However, the implementation is incomplete and introduces several critical runtime errors. The new Pydantic models (SavedMessageListQuery and SavedMessageCreatePayload) are used without being defined or imported. Additionally, there's a reference to a non-existent variable args after the refactoring. I've also pointed out a few minor code quality issues. These critical issues must be addressed for the code to be functional.

[Copilot]

Pull request overview

This pull request refactors the api/controllers/web/saved_message.py file as part of a larger effort (#29289) to modernize the codebase by replacing Flask-RESTX's reqparse with Pydantic models for request validation. The changes introduce type-safe data validation using Pydantic BaseModels while maintaining the same API functionality.

Key Changes

• Replaced flask_restx.reqparse with Pydantic BaseModel classes for request validation
• Introduced SavedMessageListQuery and SavedMessageCreatePayload models for type-safe validation
• Migrated from uuid_value helper to UUIDStrOrEmpty type annotation
• Registered schema models for OpenAPI documentation via register_schema_models

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.