Feature to cancel ongoing XHR request if component unloaded #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SteJaySulli
commented
Mar 12, 2020
SteJaySulli
commented
- On very dynamic pages, the component could be unloaded while an XHR is ongoing
- In these circumstances and error is displayed to the console
- This is largely cosmetic; the error doesn't break functionality
- See https://github.com/axios/axios#cancellation for implementation details
- On very dynamic pages, the component could be unloaded while an XHR is ongoing - In these circumstances and error is displayed to the console - This is largely cosmetic; the error doesn't break functionality - See https://github.com/axios/axios#cancellation for implementation details
dextermb
suggested changes
Mar 12, 2020
Contributor
dextermb
left a comment
dextermb
left a comment
There was a problem hiding this comment.
This is a nice idea. It'd remove the error/warning for trying to set state for unmounted components.
Co-Authored-By: Dexter Marks-Barber <[email protected]>
Co-Authored-By: Dexter Marks-Barber <[email protected]>
Contributor
Author
|
Thanks @dextermb for the suggestions, I've merged these in. |
Contributor
|
@SteJaySulli Looks good other than minor style changes 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.