Skip to content

feat: add tree-splicer-openscad #225

Merged
langston-barrett merged 7 commits intolangston-barrett:mainfrom
fenollp:openscad
Jan 27, 2026
Merged

feat: add tree-splicer-openscad #225
langston-barrett merged 7 commits intolangston-barrett:mainfrom
fenollp:openscad

Conversation

@fenollp
Copy link
Contributor

@fenollp fenollp commented Jan 17, 2026

Also fix a panic on the CLI clap parser.

…i' is in use by both 'intra_file_splices' and 'inter_file_splices'

Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Copy link
Owner

@langston-barrett langston-barrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Copy link
Owner

@langston-barrett langston-barrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after this one change!

@langston-barrett langston-barrett enabled auto-merge (squash) January 27, 2026 14:54
@langston-barrett langston-barrett merged commit 598ce93 into langston-barrett:main Jan 27, 2026
3 checks passed
@langston-barrett
Copy link
Owner

Thanks @fenollp!

@fenollp
Copy link
Contributor Author

fenollp commented Jan 27, 2026

FYI I'm having troubles publishing that crate, due to version mismatches. It's actually not clear to me what's wrong here:

  1s tree-splicer-openscad openscad 🔗 cargo publish
    Updating crates.io index
   Packaging tree-splicer-openscad v0.7.1 (/Users/pierre/wefwefwef/tree-splicer.git/crates/tree-splicer-openscad)
    Updating crates.io index
error: failed to prepare local package for uploading

Caused by:
  failed to select a version for `tree-sitter`.
      ... required by package `tree-splicer v0.7.0`
      ... which satisfies dependency `tree-splicer = "^0.7.0"` of package `tree-splicer-openscad v0.7.1 (/Users/pierre/wefwefwef/tree-splicer.git/crates/tree-splicer-openscad)`
  versions that meet the requirements `^0.25` are: 0.25.10, 0.25.9, 0.25.8, 0.25.7, 0.25.6, 0.25.5, 0.25.4, 0.25.3, 0.25.2, 0.25.1, 0.25.0

  package `tree-sitter` links to the native library `tree-sitter`, but it conflicts with a previous package which links to `tree-sitter` as well:
  package `tree-sitter v0.26.3`
      ... which satisfies dependency `tree-sitter = ">=0.25"` (locked to 0.26.3) of package `tree-sitter-edit v0.4.0`
      ... which satisfies dependency `tree-sitter-edit = "^0.4"` (locked to 0.4.0) of package `tree-splicer v0.7.0`
      ... which satisfies dependency `tree-splicer = "^0.7.0"` of package `tree-splicer-openscad v0.7.1 (/Users/pierre/wefwefwef/tree-splicer.git/crates/tree-splicer-openscad)`
  Only one package in the dependency graph may specify the same links value. This helps ensure that only one copy of a native library is linked in the final binary. Try to adjust your dependencies so that only one package uses the `links = "tree-sitter"` value. For more information, see https://doc.rust-lang.org/cargo/reference/resolver.html#links.

  failed to select a version for `tree-sitter` which could resolve this conflict

@fenollp fenollp deleted the openscad branch January 27, 2026 17:10
@langston-barrett
Copy link
Owner

Oh, I would appreciate if you would not publish that crate. If we're going to have it in this repo, it should be published by this repo's CI. Do you need it to be available on crates.io in the short term? If so, I can cut a release.

@fenollp
Copy link
Contributor Author

fenollp commented Jan 28, 2026

it should be published by this repo's CI
That's alright by me. I'm not sure how to do any of that so I just added you as an owner to https://crates.io/crates/tree-splicer-openscad

@langston-barrett
Copy link
Owner

Thank you! It'll get uploaded to crates.io as part of the release process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants