Skip to content

updated error checking for custom readers #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpulidojr merged 1 commit into from
Oct 1, 2025
Merged

updated error checking for custom readers #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions dsi/dsi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,10 @@ def read(self, filenames, reader_name, table_name = None):

Recommended when the input file contains a single table for the `CSV`, `Parquet`, `JSON`, or `Ensemble` reader.
"""
if isinstance(filenames, str) and not os.path.exists(filenames):
# only DSI-repo readers require filename input. Custom readers do not.
if isinstance(filenames, str) and not os.path.exists(filenames) and not reader_name.endswith(".py"):
sys.exit("read() ERROR: The input file must be a valid filepath. Please check again.")
if isinstance(filenames, list) and not all(os.path.exists(f) for f in filenames):
if isinstance(filenames, list) and not all(os.path.exists(f) for f in filenames) and not reader_name.endswith(".py"):
sys.exit("read() ERROR: All input files must have a valid filepath. Please check again.")

if reader_name.endswith(".py"):
Expand Down Expand Up @@ -200,9 +201,6 @@ def read(self, filenames, reader_name, table_name = None):

if class_name == None:
sys.exit(f"read() Error: The custom Reader must be structured as a Class in the Python script.")
if init_params == []:
print("read() Error: The custom Reader must be DSI-compatible.")
sys.exit("Please review https://lanl.github.io/dsi/dev_readers.html to ensure it is compatible.")

updated = {}
for param in init_params:
Expand Down Expand Up @@ -741,9 +739,6 @@ def write(self, filename, writer_name, table_name = None):

if class_name == None:
sys.exit(f"write() Error: The custom Writer must be structured as a Class in the Python script.")
if init_params == []:
print("write() Error: The custom Writer must be DSI-compatible.")
sys.exit("Please review https://lanl.github.io/dsi/dev_writers.html to ensure it is compatible.")

updated = {}
for param in init_params:
Expand Down