Fix optional laravel route parameters#76
Open
whitespacecode wants to merge 1 commit intolaracasts:masterfrom
Open
Fix optional laravel route parameters#76whitespacecode wants to merge 1 commit intolaracasts:masterfrom
whitespacecode wants to merge 1 commit intolaracasts:masterfrom
Conversation
Update laravel-routes.js to fix having optional route parameters
Author
|
Fix for optional parameters in the laravel route In this example, the regular expression |
|
I just ran into this myself, but the regex I came up with is a little different. The problem I see with the one proposed here is that it will also match for example |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update laravel-routes.js to fix having optional route parameters