Skip to content

Fix the flaky logout test #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 24, 2025
Merged

Fix the flaky logout test #3

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5feb26c
Fix the logout test to use XPath for username click
pushpak1300 Sep 20, 2025
a628f34
Update tests/Browser/Auth/AuthenticationTest.php
crynobone Sep 22, 2025
816cb9b
Use data-test attribute instead of xpath
pushpak1300 Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/Browser/Auth/AuthenticationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
actingAs($user);

visit(route('dashboard'))
->click($user->name)
->click("//button[.//*[normalize-space(text())='$user->name']]")
->click('@logout-button')
->assertUrlIs(route('home'))
->assertNoConsoleLogs()
Expand Down