Fix tsc error in Pages/Auth/Login.tsx on fresh install#457
Merged
taylorotwell merged 1 commit intolaravel:2.xfrom Jan 26, 2025
Merged
Fix tsc error in Pages/Auth/Login.tsx on fresh install#457taylorotwell merged 1 commit intolaravel:2.xfrom
taylorotwell merged 1 commit intolaravel:2.xfrom
Conversation
Typescript treats the `remember: false` as a literal type in the useForm call, which makes `tsc` fail when the checkbox calls `setData` with a boolean. This commit tells `tsc` to treat false as a boolean, which fixes the `tsc` error and makes `npm run build` pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typescript treats the
remember: falseas a literal type in the useForm call, which makestscfail when the checkbox callssetDatawith a boolean.This happens on a fresh install:
This commit tells typescript to treat
falseas a boolean, which fixes thetscerror and makesnpm run buildpass