Add test for redirect on verification.verify route for verified user#461
Closed
lokomilo wants to merge 1 commit intolaravel:2.xfrom
lokomilo:patch-2
Closed
Add test for redirect on verification.verify route for verified user#461lokomilo wants to merge 1 commit intolaravel:2.xfrom lokomilo:patch-2
verification.verify route for verified user#461lokomilo wants to merge 1 commit intolaravel:2.xfrom
lokomilo:patch-2
Conversation
An already verified user visiting the `verification.verify` route is redirected to the dashboard without dispatching the `Verified` event. This occurs on line 18 in `stubs/default/app/Http/Controllers/Auth/VerifyEmailController.php` and line 18 in `stubs/inertia-common/app/Http/Controllers/Auth/VerifyEmailController.php`. This functionality does not seem to be tested. This pull request adds a test for the path.
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An already verified user visiting the
verification.verifyroute is redirected to the dashboard without dispatching theVerifiedevent.This occurs on line 18 in stubs/default/app/Http/Controllers/Auth/VerifyEmailController.php and line 18 in stubs/inertia-common/app/Http/Controllers/Auth/VerifyEmailController.php.
This functionality does not seem to be tested.
This pull request adds a test for the path.