Skip to content

[16.x] refactor: remove redundant parameter annotations in docblocks#1807

Closed
nguyentranchung wants to merge 2 commits intolaravel:16.xfrom
nguyentranchung:pr-format
Closed

[16.x] refactor: remove redundant parameter annotations in docblocks#1807
nguyentranchung wants to merge 2 commits intolaravel:16.xfrom
nguyentranchung:pr-format

Conversation

@nguyentranchung
Copy link
Contributor

style: clean up test cases and improve code consistency

docs: update method docblocks to remove unnecessary parameter annotations

style: clean up test cases and improve code consistency

docs: update method docblocks to remove unnecessary parameter annotations
@nguyentranchung
Copy link
Contributor Author

format log


  .........✓✓..✓✓..✓............✓✓........✓✓✓✓✓.✓.✓✓✓✓✓.✓✓✓.✓✓✓✓✓✓✓✓✓✓.✓✓.✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓.

  ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── Laravel  
    FIXED   ..................................................................................................................... 90 files, 50 style issues fixed  
  ✓ src/Cashier.php                                                                                 new_with_parentheses, no_superfluous_phpdoc_tags, phpdoc_trim  
  ✓ src/CashierServiceProvider.php                                                                                        no_superfluous_phpdoc_tags, phpdoc_trim  
  ✓ src/Checkout.php                      new_with_parentheses, no_superfluous_phpdoc_tags, unary_operator_spaces, phpdoc_trim, not_operator_with_successor_space  
  ✓ src/CheckoutBuilder.php                                                                                               no_superfluous_phpdoc_tags, phpdoc_trim  
  ✓ src/Concerns/AllowsCoupons.php                              no_superfluous_phpdoc_tags, unary_operator_spaces, phpdoc_trim, not_operator_with_successor_space  
  ✓ src/Concerns/HandlesPaymentFailures.php                                                                               no_superfluous_phpdoc_tags, phpdoc_trim  
  ✓ src/Concerns/HandlesTaxes.php                                                                                         no_superfluous_phpdoc_tags, phpdoc_trim  
  ✓ src/Concerns/InteractsWithPaymentBehavior.php                                                                         no_superfluous_phpdoc_tags, phpdoc_trim  
  ✓ src/Concerns/InteractsWithStripe.php                                                                                               no_superfluous_phpdoc_tags  
  ✓ src/Concerns/ManagesCustomer.php      new_with_parentheses, no_superfluous_phpdoc_tags, unary_operator_spaces, phpdoc_trim, not_operator_with_successor_space  
  ✓ src/Concerns/ManagesInvoices.php      new_with_parentheses, no_superfluous_phpdoc_tags, unary_operator_spaces, phpdoc_trim, not_operator_with_successor_space  
  ✓ src/Concerns/ManagesPaymentMethods.php new_with_parentheses, no_superfluous_phpdoc_tags, unary_operator_spaces, phpdoc_trim, not_operator_with_successor_spa…  
  ✓ src/Concerns/ManagesSubscriptions.php                       no_superfluous_phpdoc_tags, unary_operator_spaces, phpdoc_trim, not_operator_with_successor_space  
  ✓ src/Concerns/ManagesUsageBilling.php                        no_superfluous_phpdoc_tags, unary_operator_spaces, phpdoc_trim, not_operator_with_successor_space  
  ✓ src/Concerns/PerformsCharges.php                                                                                      no_superfluous_phpdoc_tags, phpdoc_trim  
  ✓ src/Concerns/Prorates.php                                                                                             no_superfluous_phpdoc_tags, phpdoc_trim  
  ✓ src/Contracts/InvoiceRenderer.php                                                                                     no_superfluous_phpdoc_tags, phpdoc_trim  
  ✓ src/Coupon.php                                              no_superfluous_phpdoc_tags, unary_operator_spaces, phpdoc_trim, not_operator_with_successor_space  
  ✓ src/CustomerBalanceTransaction.php                                                                                    no_superfluous_phpdoc_tags, phpdoc_trim  
  ✓ src/Discount.php                                            no_superfluous_phpdoc_tags, unary_operator_spaces, phpdoc_trim, not_operator_with_successor_space  
  ✓ src/Events/WebhookHandled.php                                                                                                      no_superfluous_phpdoc_tags  
  ✓ src/Events/WebhookReceived.php                                                                                                     no_superfluous_phpdoc_tags  
  ✓ src/Exceptions/IncompletePayment.php                                                                                               no_superfluous_phpdoc_tags  
  ✓ src/Exceptions/InvalidCoupon.php                                                                                                   no_superfluous_phpdoc_tags  
  ✓ src/Exceptions/InvalidCustomerBalanceTransaction.php                                                                               no_superfluous_phpdoc_tags  
  ✓ src/Exceptions/InvalidInvoice.php                                                                                                  no_superfluous_phpdoc_tags  
  ✓ src/Exceptions/InvalidPaymentMethod.php                                                                                            no_superfluous_phpdoc_tags  
  ✓ src/Exceptions/SubscriptionUpdateFailure.php                                                                                       no_superfluous_phpdoc_tags  
  ✓ src/Http/Controllers/WebhookController.php                               no_superfluous_phpdoc_tags, unary_operator_spaces, not_operator_with_successor_space  
  ✓ src/Http/Middleware/VerifyRedirectUrl.php                                no_superfluous_phpdoc_tags, unary_operator_spaces, not_operator_with_successor_space  
  ✓ src/Http/Middleware/VerifyWebhookSignature.php                                                                                     no_superfluous_phpdoc_tags  
  ✓ src/Invoice.php                                             no_superfluous_phpdoc_tags, unary_operator_spaces, phpdoc_trim, not_operator_with_successor_space  
  ✓ src/InvoiceLineItem.php                                     no_superfluous_phpdoc_tags, unary_operator_spaces, phpdoc_trim, not_operator_with_successor_space  
  ✓ src/InvoicePayment.php                                                                                                no_superfluous_phpdoc_tags, phpdoc_trim  
  ✓ src/Logger.php                                                                                                                     no_superfluous_phpdoc_tags  
  ✓ src/Notifications/ConfirmPayment.php                                                                                               no_superfluous_phpdoc_tags  
  ✓ src/Payment.php                                                                                                       no_superfluous_phpdoc_tags, phpdoc_trim  
  ✓ src/PaymentMethod.php                                                                                                 no_superfluous_phpdoc_tags, phpdoc_trim  
  ✓ src/PromotionCode.php                                                                                                 no_superfluous_phpdoc_tags, phpdoc_trim  
  ✓ src/Subscription.php                                        no_superfluous_phpdoc_tags, unary_operator_spaces, phpdoc_trim, not_operator_with_successor_space  
  ✓ src/SubscriptionBuilder.php                                 no_superfluous_phpdoc_tags, unary_operator_spaces, phpdoc_trim, not_operator_with_successor_space  
  ✓ src/SubscriptionItem.php              new_with_parentheses, no_superfluous_phpdoc_tags, unary_operator_spaces, phpdoc_trim, not_operator_with_successor_space  
  ✓ src/Tax.php                                                                                                           no_superfluous_phpdoc_tags, phpdoc_trim  
  ✓ tests/Feature/LoggerTest.php                                                                                             php_unit_set_up_tear_down_visibility  
  ✓ tests/Feature/VerifyWebhookSignatureTest.php                               new_with_parentheses, php_unit_set_up_tear_down_visibility, single_line_empty_body  
  ✓ tests/Unit/CustomerTest.php                                                                                                              new_with_parentheses  
  ✓ tests/Unit/InvoiceLineItemTest.php                                                                           new_with_parentheses, no_superfluous_phpdoc_tags  
  ✓ tests/Unit/InvoiceTest.php                                                                                                               new_with_parentheses  
  ✓ tests/Unit/PaymentTest.php                                                                                              new_with_parentheses, phpdoc_tag_type  
  ✓ tests/Unit/SubscriptionTest.php                                                                                                          new_with_parentheses  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants